Remove note that's no longer the case #4645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jan 25, 2015
… parameters are changed (thewilkybarkid) This PR was merged into the 2.3 branch. Discussion ---------- Make the container considered non-fresh if the environment parameters are changed | Q | A | ------------- | --- | Bug fix? | not really | New feature? | kind of | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11365 | License | MIT | Doc PR | symfony/symfony-docs#4645 Fixes #11365 by making the container non-fresh if any of the prefixed environment parameters are added/removed/changed. Not a bug as it was documented as behaving as such, but I think it's worth applying to 2.3 rather than considering it a new feature. Commits ------- b49fa12 Make the container considered non-fresh if the environment parameters are changed
fabpot
added a commit
to symfony/http-kernel
that referenced
this pull request
Jan 25, 2015
… parameters are changed (thewilkybarkid) This PR was merged into the 2.3 branch. Discussion ---------- Make the container considered non-fresh if the environment parameters are changed | Q | A | ------------- | --- | Bug fix? | not really | New feature? | kind of | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11365 | License | MIT | Doc PR | symfony/symfony-docs#4645 Fixes #11365 by making the container non-fresh if any of the prefixed environment parameters are added/removed/changed. Not a bug as it was documented as behaving as such, but I think it's worth applying to 2.3 rather than considering it a new feature. Commits ------- b49fa12 Make the container considered non-fresh if the environment parameters are changed
|
The pull request was merged in the code repository. Thanks @thewilkybarkid! 👍 |
|
Cool, well done! |
weaverryan
added a commit
that referenced
this pull request
Jan 30, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Remove note that's no longer the case | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | symfony/symfony#12972 changes the behaviour so that this note is no longer required. Commits ------- de8b547 Remove note that's no longer the case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/symfony#12972 changes the behaviour so that this note is no longer required.